Add justfile and update CONTRIBUTING.md#3240
Merged
UnknownPlatypus merged 4 commits intotypeddjango:masterfrom Apr 4, 2026
Merged
Add justfile and update CONTRIBUTING.md#3240UnknownPlatypus merged 4 commits intotypeddjango:masterfrom
UnknownPlatypus merged 4 commits intotypeddjango:masterfrom
Conversation
Contributor
Author
|
@sobolevn @emmanuel-ferdman Could you try checking this branch out and testing the just commands ? |
Contributor
emmanuel-ferdman
left a comment
emmanuel-ferdman
left a comment
There was a problem hiding this comment.
Really great work, thanks for putting this together! Personally, I'm more familiar with make but this is was really straightforward and well-structured. Tested locally and works well. I have a few suggestions :)
- Reorder bootstrap: run uv sync before pre-commit install - Add ext-test to pre-mr-check dependencies - Default test args to 'tests' so `just test path/to/file` overrides it - Remove unnecessary -- separator in CONTRIBUTING.md examples
sobolevn
reviewed
Apr 2, 2026
4 tasks
Contributor
Author
|
Thanks for the feedback, I think I've addressed every suggestions. I'm going to merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #320
Fixes #1273
I personally mostly use
just pre-mr-checkbefore submitting a PR to avoid unnecessary ci errors